Skip to content

fix(mcp): relax column name regex, improve generate_chart validation errors and examples #39915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
aminghadersohi wants to merge 6 commits into
base: master
Choose a base branch
from
+256 −16

fix(mcp): make test_script_tag_neutralized nh3-version-agnostic

24ad34f
Select commit
Loading
Failed to load commit list.
Draft

fix(mcp): relax column name regex, improve generate_chart validation errors and examples #39915

fix(mcp): make test_script_tag_neutralized nh3-version-agnostic
24ad34f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 7, 2026 in 1s

63.87% (-0.50%) compared to 673634f

View this Pull Request on Codecov

63.87% (-0.50%) compared to 673634f

Details

Codecov Report

❌ Patch coverage is 10.86957% with 41 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.87%. Comparing base (673634f) to head (24ad34f).
⚠️ Report is 37 commits behind head on master.

Files with missing lines Patch % Lines
...t/mcp_service/chart/validation/schema_validator.py 9.09% 20 Missing ⚠️
superset/mcp_service/chart/tool/generate_chart.py 0.00% 17 Missing ⚠️
superset/mcp_service/chart/schemas.py 42.85% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #39915      +/-   ##
==========================================
- Coverage   64.37%   63.87%   -0.50%     
==========================================
  Files        2569     2583      +14     
  Lines      134745   136692    +1947     
  Branches    31278    31519     +241     
==========================================
+ Hits        86739    87313     +574     
- Misses      46508    47863    +1355     
- Partials     1498     1516      +18

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov