Skip to content

fix(mcp): apply consistent NaN+bool guards to scatter extractor and s…

a560f84
Select commit
Loading
Failed to load commit list.
Merged

fix(mcp): ASCII chart crashes with NaN when dataset contains null values #39916

fix(mcp): apply consistent NaN+bool guards to scatter extractor and s…
a560f84
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 7, 2026 in 1s

63.87% (-0.02%) compared to 5b5dd01

View this Pull Request on Codecov

63.87% (-0.02%) compared to 5b5dd01

Details

Codecov Report

❌ Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.87%. Comparing base (5b5dd01) to head (a560f84).
⚠️ Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
superset/mcp_service/chart/ascii_charts.py 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #39916      +/-   ##
==========================================
- Coverage   63.88%   63.87%   -0.02%     
==========================================
  Files        2583     2583              
  Lines      136604   136629      +25     
  Branches    31502    31506       +4     
==========================================
  Hits        87276    87276              
- Misses      47812    47837      +25     
  Partials     1516     1516              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.