Skip to content

allow clearing database/schema in DatasourceModal #39918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gfody wants to merge 2 commits into
base: master
Choose a base branch
from
+5 −5
Open

allow clearing database/schema in DatasourceModal #39918

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
261d0a6
allow clearing database/schema (fixes #36683 and #33573)
gfody May 6, 2026
bc223d8
Allow database_id to be None in DatasetPutSchema
gfody May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions superset-frontend/src/components/Datasource/DatasourceModal/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,14 +113,14 @@ const DatasourceModal: FunctionComponent<DatasourceModalProps> = ({
const buildPayload = (datasource: Record<string, any>) => {
const payload: Record<string, any> = {
table_name: datasource.table_name,
database_id: datasource.database?.id,
database_id: datasource.database?.id ?? null,
Comment thread
gfody marked this conversation as resolved.
Comment thread
gfody marked this conversation as resolved.
sql: datasource.sql,
filter_select_enabled: datasource.filter_select_enabled,
fetch_values_predicate: datasource.fetch_values_predicate,
schema:
datasource.tableSelector?.schema ||
datasource.databaseSelector?.schema ||
datasource.schema,
datasource.tableSelector?.schema ??
datasource.databaseSelector?.schema ??
datasource.schema ?? null,
description: datasource.description,
main_dttm_col: datasource.main_dttm_col,
currency_code_column: datasource.currency_code_column ?? null,
Expand Down
Loading