Skip to content

fix(mcp): address reviewer feedback on DetachedInstanceError fix

546c805
Select commit
Loading
Failed to load commit list.
Merged

fix(mcp): prevent DetachedInstanceError in get_chart_preview #39921

fix(mcp): address reviewer feedback on DetachedInstanceError fix
546c805
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 7, 2026 in 1s

63.88% (-0.01%) compared to 5b5dd01, passed because coverage increased by 0% when compared to adjusted base (63.88%)

View this Pull Request on Codecov

63.88% (-0.01%) compared to 5b5dd01, passed because coverage increased by 0% when compared to adjusted base (63.88%)

Details

Codecov Report

❌ Patch coverage is 14.28571% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.88%. Comparing base (5b5dd01) to head (546c805).

Files with missing lines Patch % Lines
...perset/mcp_service/chart/tool/get_chart_preview.py 14.28% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #39921      +/-   ##
==========================================
- Coverage   63.88%   63.88%   -0.01%     
==========================================
  Files        2583     2583              
  Lines      136604   136610       +6     
  Branches    31502    31503       +1     
==========================================
  Hits        87276    87276              
- Misses      47812    47818       +6     
  Partials     1516     1516              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.