Skip to content

feat(mcp): chart type plugin registry for extensible generate_chart #39922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
aminghadersohi wants to merge 7 commits into
base: master
Choose a base branch
from

refactor(mcp): move all local imports to top level in chart type plugins

1e2b541
Select commit
Loading
Failed to load commit list.
Draft

feat(mcp): chart type plugin registry for extensible generate_chart #39922

refactor(mcp): move all local imports to top level in chart type plugins
1e2b541
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 7, 2026 in 0s

63.90% (+0.02%) compared to ad5e317

View this Pull Request on Codecov

63.90% (+0.02%) compared to ad5e317

Details

Codecov Report

❌ Patch coverage is 34.41781% with 383 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.90%. Comparing base (ad5e317) to head (1e2b541).

Files with missing lines Patch % Lines
superset/mcp_service/chart/plugins/xy.py 29.33% 53 Missing ⚠️
...rset/mcp_service/chart/plugins/mixed_timeseries.py 26.98% 46 Missing ⚠️
superset/mcp_service/chart/plugins/big_number.py 29.03% 44 Missing ⚠️
superset/mcp_service/chart/plugins/handlebars.py 28.81% 42 Missing ⚠️
superset/mcp_service/chart/plugins/pivot_table.py 31.48% 37 Missing ⚠️
superset/mcp_service/chart/plugins/pie.py 38.63% 27 Missing ⚠️
superset/mcp_service/chart/registry.py 45.45% 22 Missing and 2 partials ⚠️
superset/mcp_service/chart/plugins/table.py 42.50% 23 Missing ⚠️
superset/mcp_service/chart/chart_utils.py 0.00% 20 Missing ⚠️
.../mcp_service/chart/validation/dataset_validator.py 14.28% 18 Missing ⚠️
... and 4 more
Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #39922      +/-   ##
==========================================
+ Coverage   63.88%   63.90%   +0.02%     
==========================================
  Files        2583     2593      +10     
  Lines      136618   136938     +320     
  Branches    31502    31513      +11     
==========================================
+ Hits        87272    87504     +232     
- Misses      47830    47916      +86     
- Partials     1516     1518       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov