feat: reuse Sessions correctly in BasicCrawler#3605
Open
barjin wants to merge 3 commits intorefactor/proxy-configuration-drop-requestfrom
Open
feat: reuse Sessions correctly in BasicCrawler#3605barjin wants to merge 3 commits intorefactor/proxy-configuration-drop-requestfrom
Sessions correctly in BasicCrawler#3605barjin wants to merge 3 commits intorefactor/proxy-configuration-drop-requestfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR changes BasicCrawler’s session lifecycle so that sessions are no longer forced into single-use, and introduces proxy assignment at session creation time to keep proxyInfo consistent with the Session instance.
Changes:
- Replace per-request single-use session creation with
SessionPool.getSession()to allow session reuse. - When
proxyConfigurationis used, assignproxyInfowhen creating sessions in the pool and expose it via context. - Add a test asserting
proxyInfois present on both theSessionand the handler context.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
packages/basic-crawler/src/internals/basic-crawler.ts |
Switch to session reuse via getSession() and introduce a custom createSessionFunction that assigns proxyInfo. |
test/core/crawlers/basic_crawler.test.ts |
Add coverage for proxyConfiguration producing proxyInfo on Session and in the handler context. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes BasicCrawler (and its subclasses) reuse
Sessioninstances according to thesessionReuseStrategy. Before, theBasicCrawlerwould create a single-use Session for each Request unless instructed otherwise (e.g., viarequest.sessionId).Refactors small bits around the
Sessionlifecycle inBasicCrawler.Closes #3595
Depends on #3599