fix: honor persistCookiesPerSession: false in HttpCrawler#3606
Open
barjin wants to merge 1 commit intofeat/session-reuse-in-basic-crawlerfrom
Open
fix: honor persistCookiesPerSession: false in HttpCrawler#3606barjin wants to merge 1 commit intofeat/session-reuse-in-basic-crawlerfrom
persistCookiesPerSession: false in HttpCrawler#3606barjin wants to merge 1 commit intofeat/session-reuse-in-basic-crawlerfrom
Conversation
The flag had become a no-op after cookie handling moved into `BaseHttpClient`: response `Set-Cookie` headers were always written back into the session jar regardless of the flag's value. Pass a per-request clone of the jar when the flag is off so reads keep working but writes are discarded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The flag had become a no-op after cookie handling moved into
BaseHttpClient- responseSet-Cookieheaders were always written back into the session jar regardless of the flag's value.Pass a per-request clone of the jar when the flag is off, so reads keep working, but writes are discarded.
This PR also adds several regression tests for cookie-related behaviour.
Together with the other
Session-related fixes, this closes #3271 inv4.