Add support for SiteEncrypt.Phoenix.Endpoint detection#339
Merged
zachdaniel merged 2 commits intoash-project:mainfrom Oct 14, 2025
Merged
Conversation
Enhanced endpoint detection functions to support SiteEncrypt.Phoenix.Endpoint in addition to Phoenix.Endpoint. This allows Igniter to work with projects that use SiteEncrypt for automatic SSL certificate management. Changes: - Updated select_endpoint/3 to detect both Phoenix.Endpoint and SiteEncrypt.Phoenix.Endpoint - Updated endpoints_for_router/2 to detect both endpoint types - Added comprehensive tests for SiteEncrypt.Phoenix.Endpoint support
zachdaniel
reviewed
Oct 13, 2025
As suggested in PR review, refactored the endpoint detection to use a module attribute @endpoint_modules and Enum.find_value/2 to check for matching endpoint types. This makes it easier to add more endpoint types in the future and reduces code duplication.
zachdaniel
approved these changes
Oct 14, 2025
Contributor
|
🚀 Thank you for your contribution! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhanced endpoint detection functions to support SiteEncrypt.Phoenix.Endpoint in addition to Phoenix.Endpoint. This allows Igniter to work with projects that use SiteEncrypt for automatic SSL certificate management.
Changes:
Updated select_endpoint/3 to detect both Phoenix.Endpoint and SiteEncrypt.Phoenix.Endpoint
Updated endpoints_for_router/2 to detect both endpoint types
I accept the AI Policy.
Bug fixes include regression tests
Chores
Documentation changes
Features include unit tests
Refactoring
Update dependencies