Skip to content

chore: Remove unused require statements as picked up by the Elixir 1.20.0-rc.1 compiler#356

Merged
zachdaniel merged 1 commit intomainfrom
fix/elixir-1.20-warnings
Jan 17, 2026
Merged

chore: Remove unused require statements as picked up by the Elixir 1.20.0-rc.1 compiler#356
zachdaniel merged 1 commit intomainfrom
fix/elixir-1.20-warnings

Conversation

@sevenseacat
Copy link
Copy Markdown
Contributor

There's still one type warning in assert_has_issue:

     warning: unknown key .issues in expression:

         igniter.issues

     the given type does not have the given key:

         dynamic(%Rewrite{
           sources: term(),
           extensions: term(),
           hooks: term(),
           dot_formatter: term(),
           excluded: term()
         })

     where "igniter" was given the type:

         # type: dynamic(%Rewrite{})
         # from: lib/igniter/test.ex:427:24
         Rewrite.source(igniter, path)

     typing violation found at:
     │
 435 │       if !Enum.any?(igniter.issues, fn found_issue ->
     │                             ~~~~~~
     │
     └─ (igniter 0.7.0) lib/igniter/test.ex:435:29: Igniter.Test.assert_has_issue/3

But I thought I'd fix the low-hanging fruit. :)

Contributor checklist

Leave anything that you believe does not apply unchecked.

  • I accept the AI Policy, or AI was not used in the creation of this PR.
  • Bug fixes include regression tests
  • Chores
  • Documentation changes
  • Features include unit/acceptance tests
  • Refactoring
  • Update dependencies

@zachdaniel zachdaniel merged commit a845564 into main Jan 17, 2026
42 of 44 checks passed
@febarnett3 febarnett3 mentioned this pull request May 5, 2026
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants