fix: handle children = [...] ++ expr in add_new_child#368
Merged
zachdaniel merged 1 commit intomainfrom Mar 24, 2026
Merged
Conversation
`add_new_child` failed to insert children when the Application module used list concatenation (e.g. `children = [...] ++ target_children()`), which is the standard pattern generated by `mix nerves.new`. The `children = expr` match required the RHS to be a literal list, but with `++` the AST node is a function call. This adds a fallback that matches `children = [...] ++ expr` and navigates into the literal list (first operand of `++`) as the insertion target.
Contributor
|
🚀 Thank you for your contribution! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
add_new_child/3now handles Application modules where the children assignment uses list concatenation (children = [...] ++ target_children()), which is the standard pattern generated bymix nerves.newadd_child_to_list/4to avoid duplication between the simple list and++code paths[...] ++ exprform is handled (list on the left); the reverseexpr ++ [...]is not matchedTest plan
++concatenation++concatenation