Disable Crossgen2 Json CG2 composite job#2177
Merged
LoopedBard3 merged 1 commit intoJun 4, 2026
Merged
Conversation
The CG2 composite profile for the Json crossgen2 scenario consistently hits ILCompiler.CodeGenerationFailedException (IndexOutOfRangeException in CorInfoImpl.HandleToModuleToken) during publish, and on Windows runs has caused crank to hang, blocking the rest of the jobs in benchmarks-ci-01 and benchmarks-ci-02. Disable it via its condition until the underlying crossgen2 issue is resolved. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
DrewScoggins
approved these changes
Jun 4, 2026
There was a problem hiding this comment.
Pull request overview
This PR disables the CG2 composite crossgen2 profile in the shared build/crossgen2-scenarios.yml template to prevent recurring crossgen2 composite publish failures (and associated Windows crank hangs) from blocking the rest of the CI pipeline.
Changes:
- Disabled the
CG2 compositeprofile by setting itsconditionto'false'. - Added inline documentation explaining why the profile is disabled (failure + pipeline impact).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+36
to
+38
| # Disabled: consistently fails with ILCompiler.CodeGenerationFailedException (IndexOutOfRangeException | ||
| # in CorInfoImpl.HandleToModuleToken) during the crossgen2 composite publish, and on Windows runs has | ||
| # caused crank to hang, blocking the rest of the jobs in the pipeline. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disables the
CG2 compositeprofile inbuild/crossgen2-scenarios.yml(used by bothbenchmarks-ci-01andbenchmarks-ci-02) by flipping itsconditionto'false', matching the pattern already used for theCG2 composite avx2profile.Why
The Json CG2 composite job has been consistently failing during the crossgen2 composite publish step with:
On the Windows leg this has additionally caused
crankto hang/get stuck, which then prevents all of the remaining jobs in the pipeline from running. Disabling the profile keeps the rest of the crossgen2 scenarios (Default, CG2 non-composite) running while we wait for the underlying crossgen2 issue to be resolved.Scope
CG2 compositeprofile entry under the sharedcrossgen2-scenarios.ymltemplate is changed; bothbenchmarks-ci-01.ymlandbenchmarks-ci-02.ymlconsume this template, so the job is disabled in both pipelines with a single change.Default,CG2 non-composite, and the already-disabledCG2 composite avx2profiles are unchanged.Marking as draft for review.