fix(cli): correct GitHub URL branch parsing and file extension detection#2221
Open
messiawrq-design wants to merge 1 commit into
Open
fix(cli): correct GitHub URL branch parsing and file extension detection#2221messiawrq-design wants to merge 1 commit into
messiawrq-design wants to merge 1 commit into
Conversation
Fixes asyncapi#1940. 1. Updated `githubWebPattern` in `validation.service.ts` from `([^\/]+)` to `(.+?)` for the branch capture group. This correctly allows URLs with slash-based branch names (e.g., `feature/new-validation`) to be parsed instead of throwing a 404. 2. Updated extension extraction in `SpecificationFile.ts` to use the last element of the split array (`parts[parts.length - 1]`), which gracefully supports multi-dot filenames like `my.asyncapi.yaml` and files with no extensions. Bounty Wallet: 6sF8p22Gg83NKTJ6dvya7Srv4USCniZnP47DwQwK7Mtp (Solana) / Algora
messiawrq-design
requested review from
AayushSaini101,
Amzani,
Shurtu-gal,
Souvikns and
asyncapi-bot-eve
as code owners
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1940.
Bug fixes included:
githubWebPatterninvalidation.service.tsfrom([^\/]+)to(.+?)for the branch capture group. This correctly allows URLs with slash-based branch names (e.g.,feature/new-validation) to be parsed instead of throwing a 404.name.split('.')[1]extraction inSpecificationFile.tsto intelligently use the last element of the split array (parts[parts.length - 1]). This gracefully handles multi-dot filenames likemy.asyncapi.yamland single-word files.Bounty Wallet: 6sF8p22Gg83NKTJ6dvya7Srv4USCniZnP47DwQwK7Mtp (Solana) / Algora