Write a SerDes lifecycle test for memory leak validation using ASan#469
Open
isaurab007 wants to merge 1 commit intoawslabs:native-schema-registry-releasefrom
Open
Conversation
knoxy5467
approved these changes
Sep 30, 2025
Contributor
knoxy5467
left a comment
knoxy5467
left a comment
There was a problem hiding this comment.
Please raise an issue with Graalvm about their memory leak.
Comment on lines
+73
to
+74
| # There are memory leaks in graal_create_isolate. Uncomment after fixing. | ||
| # schema_registry_memory_leak_test |
Contributor
There was a problem hiding this comment.
Can this be more descriptive as to where and what the memory leak is from?
| read_only_byte_array_test | ||
| mutable_byte_array_test | ||
| glue_schema_registry_error_test | ||
| # There are memory leaks in graal_create_isolate. Uncomment after fixing. |
Contributor
There was a problem hiding this comment.
graal_create is outside of our projects scope correct? Additionally if there are leaks in graalvm then we should raise and issue on their repo.
| include(cmake/CodeCoverage.cmake) | ||
| set(min_code_coverage 100) | ||
| setup_target_for_coverage(coverage "ctest ." coverage ${min_code_coverage}) | ||
| endif() No newline at end of file |
Contributor
There was a problem hiding this comment.
NIT: unneeded formatting changes. Only fix if second revision is needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Right now, although ASan is integrated with our build system, there is no test for the SerDes lifecycle (initiate, encode/dispose, dispose) and multiple encode/decode iterations in the C layer. Hence, there is no way to catch memory leaks in this flow.
Description of changes:
This PR adds these tests where it covers:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.