Skip to content

[Java] Remove AWS SDK v1 STS dependency from multilang-schema-registry#504

Open
jvdadda wants to merge 1 commit intoawslabs:masterfrom
mobsuccess-devops:remove-sdk-v1-sts-multilang
Open

[Java] Remove AWS SDK v1 STS dependency from multilang-schema-registry#504
jvdadda wants to merge 1 commit intoawslabs:masterfrom
mobsuccess-devops:remove-sdk-v1-sts-multilang

Conversation

@jvdadda
Copy link
Copy Markdown

@jvdadda jvdadda commented Mar 9, 2026

Issue #, if available: #500

Description of changes:

Remove the com.amazonaws:aws-java-sdk-sts (AWS SDK v1) dependency from the multilang-schema-registry module. The v2 equivalent software.amazon.awssdk:sts is already declared and no v1 STS classes are used in source code.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copilot AI review requested due to automatic review settings March 9, 2026 08:55
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the AWS Java SDK v1 STS dependency (com.amazonaws:aws-java-sdk-sts) to support the repo-wide SDK v1 removal effort (#500), relying on the AWS SDK v2 STS artifact (software.amazon.awssdk:sts) instead.

Changes:

  • Remove aws-java-sdk-sts dependency from multilang-schema-registry.
  • Remove aws-java-sdk-sts dependency from serializer-deserializer.
  • Update Javadoc/test comments to reference AwsCredentialsProvider (v2) instead of AWSCredentialsProvider (v1).

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
serializer-deserializer/src/test/java/com/amazonaws/services/schemaregistry/deserializers/avro/AWSKafkaAvroDeserializerTest.java Updates test comment to reference v2 credentials provider naming.
serializer-deserializer/src/test/java/com/amazonaws/services/schemaregistry/deserializers/GlueSchemaRegistryKafkaDeserializerTest.java Updates test comment to reference v2 credentials provider naming.
serializer-deserializer/src/main/java/com/amazonaws/services/schemaregistry/deserializers/avro/AWSKafkaAvroDeserializer.java Updates constructor Javadoc to reference v2 credentials provider naming.
serializer-deserializer/src/main/java/com/amazonaws/services/schemaregistry/deserializers/GlueSchemaRegistryKafkaDeserializer.java Updates constructor Javadoc to reference v2 credentials provider naming.
serializer-deserializer/pom.xml Drops AWS SDK v1 STS dependency.
multilang-schema-registry/pom.xml Drops AWS SDK v1 STS dependency.
Comments suppressed due to low confidence (1)

serializer-deserializer/pom.xml:66

  • PR metadata says this change is scoped to removing the AWS SDK v1 STS dependency from multilang-schema-registry and that it depends on #503, but this PR also removes aws-java-sdk-sts from serializer-deserializer (and updates related Javadoc/tests). Please align the PR title/description (or drop the serializer-deserializer changes) so the scope and dependency relationship are clear and we don’t duplicate/overlap work with #503.
    <dependencies>
        <dependency>
            <groupId>software.amazon.awssdk</groupId>
            <artifactId>sts</artifactId>
            <version>${aws.sdk.v2.version}</version>

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

The v2 equivalent software.amazon.awssdk:sts is already declared
and no v1 STS classes are used in source code.
@jvdadda jvdadda changed the title Remove AWS SDK v1 STS dependency from multilang-schema-registry [Java] Remove AWS SDK v1 STS dependency from multilang-schema-registry Mar 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants