[Java] Remove AWS SDK v1 STS dependency from multilang-schema-registry#504
Open
jvdadda wants to merge 1 commit intoawslabs:masterfrom
Open
[Java] Remove AWS SDK v1 STS dependency from multilang-schema-registry#504jvdadda wants to merge 1 commit intoawslabs:masterfrom
jvdadda wants to merge 1 commit intoawslabs:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Removes the AWS Java SDK v1 STS dependency (com.amazonaws:aws-java-sdk-sts) to support the repo-wide SDK v1 removal effort (#500), relying on the AWS SDK v2 STS artifact (software.amazon.awssdk:sts) instead.
Changes:
- Remove
aws-java-sdk-stsdependency frommultilang-schema-registry. - Remove
aws-java-sdk-stsdependency fromserializer-deserializer. - Update Javadoc/test comments to reference
AwsCredentialsProvider(v2) instead ofAWSCredentialsProvider(v1).
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| serializer-deserializer/src/test/java/com/amazonaws/services/schemaregistry/deserializers/avro/AWSKafkaAvroDeserializerTest.java | Updates test comment to reference v2 credentials provider naming. |
| serializer-deserializer/src/test/java/com/amazonaws/services/schemaregistry/deserializers/GlueSchemaRegistryKafkaDeserializerTest.java | Updates test comment to reference v2 credentials provider naming. |
| serializer-deserializer/src/main/java/com/amazonaws/services/schemaregistry/deserializers/avro/AWSKafkaAvroDeserializer.java | Updates constructor Javadoc to reference v2 credentials provider naming. |
| serializer-deserializer/src/main/java/com/amazonaws/services/schemaregistry/deserializers/GlueSchemaRegistryKafkaDeserializer.java | Updates constructor Javadoc to reference v2 credentials provider naming. |
| serializer-deserializer/pom.xml | Drops AWS SDK v1 STS dependency. |
| multilang-schema-registry/pom.xml | Drops AWS SDK v1 STS dependency. |
Comments suppressed due to low confidence (1)
serializer-deserializer/pom.xml:66
- PR metadata says this change is scoped to removing the AWS SDK v1 STS dependency from
multilang-schema-registryand that it depends on #503, but this PR also removesaws-java-sdk-stsfromserializer-deserializer(and updates related Javadoc/tests). Please align the PR title/description (or drop theserializer-deserializerchanges) so the scope and dependency relationship are clear and we don’t duplicate/overlap work with #503.
<dependencies>
<dependency>
<groupId>software.amazon.awssdk</groupId>
<artifactId>sts</artifactId>
<version>${aws.sdk.v2.version}</version>
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
The v2 equivalent software.amazon.awssdk:sts is already declared and no v1 STS classes are used in source code.
d4ba3ae to
41b8e93
Compare
emilie-deltil
approved these changes
Mar 9, 2026
This was referenced Mar 10, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #500
Description of changes:
Remove the
com.amazonaws:aws-java-sdk-sts(AWS SDK v1) dependency from themultilang-schema-registrymodule. The v2 equivalentsoftware.amazon.awssdk:stsis already declared and no v1 STS classes are used in source code.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.