[Java] Remove unused jimfs dependency#516
Open
jvdadda wants to merge 1 commit intoawslabs:masterfrom
Open
Conversation
The jimfs dependency was left behind after its usages were removed in PR awslabs#230. No code in the project imports any jimfs classes. The library remains available as a transitive dependency via wire-compiler for the multilang native-image build. Fixes awslabs#353
There was a problem hiding this comment.
Pull request overview
Removes an unused direct Maven dependency (com.google.jimfs:jimfs) from the schema-registry-serde module (serializer-deserializer/pom.xml), addressing #353 and reducing explicit dependency surface.
Changes:
- Remove the direct
com.google.jimfs:jimfs:1.1dependency fromserializer-deserializer/pom.xml.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: Fixes #353
Description of changes:
Remove the unused
com.google.jimfs:jimfsdirect dependency fromserializer-deserializer/pom.xml.This dependency was left behind after its usages were removed in #230. No code in the project imports any jimfs classes. The library remains available as a transitive dependency (via
wire-compiler) for themultilang-schema-registryGraalVM native-image build, so thenative-image.propertiesconfiguration continues to work.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.