[Java] Fix NullPointerException in protobuf FieldBuilder for schemas without parameters#518
Open
jvdadda wants to merge 2 commits intoawslabs:masterfrom
Open
[Java] Fix NullPointerException in protobuf FieldBuilder for schemas without parameters#518jvdadda wants to merge 2 commits intoawslabs:masterfrom
jvdadda wants to merge 2 commits intoawslabs:masterfrom
Conversation
Add null checks for fieldSchema.parameters() and fieldSchema.name() in the STRUCT type handling of FieldBuilder.build() to prevent NPE when used with Debezium or other connectors that produce schemas without protobuf metadata parameters or without schema names.
There was a problem hiding this comment.
Pull request overview
Fixes a NullPointerException encountered when converting Kafka Connect STRUCT schemas to Protobuf (notably with Debezium), by adding null guards around schema metadata access in FieldBuilder.
Changes:
- Guard against
fieldSchema.parameters()being null before checking protobuf metadata. - Guard against
fieldSchema.name()being null when deriving nested message names and when deciding whether to emit a top-level vs nested message.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
unnamed structs, add test for null parameters/name
Author
|
Addressed all three Copilot review comments in 5f7ac70:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: Fixes #289
Description of changes:
When using Debezium or other Kafka Connect source connectors with
ProtobufSchemaConverter, aNullPointerExceptionis thrown inFieldBuilder.build()becausefieldSchema.parameters()can returnnullfor STRUCT-type fields that don't carry protobuf metadata.This PR adds null guards in two places in
FieldBuilder.java:fieldSchema.parameters() != nullbefore calling.containsKey(PROTOBUF_TYPE)(line 92)fieldSchema.name() != nullbefore passing it togetSchemaSimpleName()andisParentLevel(), falling back to the field name for unnamed struct schemasBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.