[Java] Default avroRecordType to GENERIC_RECORD when not configured#519
Open
jvdadda wants to merge 2 commits intoawslabs:masterfrom
Open
[Java] Default avroRecordType to GENERIC_RECORD when not configured#519jvdadda wants to merge 2 commits intoawslabs:masterfrom
jvdadda wants to merge 2 commits intoawslabs:masterfrom
Conversation
Prevents NullPointerException in DatumReaderInstance.from() when avroRecordType is not set in Kafka Connect configuration.
There was a problem hiding this comment.
Pull request overview
Fixes a Kafka Connect deserialization NullPointerException by ensuring GlueSchemaRegistryConfiguration.avroRecordType is never null when the connector config omits avroRecordType, defaulting it to GENERIC_RECORD.
Changes:
- Default
GlueSchemaRegistryConfiguration.avroRecordTypetoAvroRecordType.GENERIC_RECORDwhen not configured.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Author
|
Addressed Copilot review: added assertion in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: Fixes #128
Description of changes:
When
avroRecordTypeis not set in the Kafka Connect connector configuration,GlueSchemaRegistryConfiguration.avroRecordTypeisnull. This null value is passed toDatumReaderInstance.from(), which performs aswitchon it, causing aNullPointerExceptionduring deserialization.The fix defaults
avroRecordTypetoGENERIC_RECORDinGlueSchemaRegistryConfiguration, which is the safest default sinceGenericDatumReaderworks without requiring specific code-generated schema classes.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.