Skip to content

fix variable-length array destructuring bug in spend-permissions complete integration example #1525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
weirdDevelop wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix variable-length array destructuring bug in spend-permissions complete integration example #1525

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/base-account/guides/verify-social-accounts.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,7 +432,7 @@ function redirectToVerifyMiniApp(provider: string) {
}
```

After verification, the user returns to your `redirect_uri` with `?success=true`. Run the check again (step 3) and it now returns 200 with a token. If you're building for the Base app, see the [Apps overview](/apps/introduction/overview) for broader app structure and lifecycle guidance.
After verification, the user returns to your `redirect_uri` with `?success=true`. Run the check again (step 3) and it now returns 200 with a token. If you're building for the Base app, see the see the [Apps overview](/apps) for broader app structure and lifecycle guidance.

</Step>
</Steps>
Expand Down
9 changes: 4 additions & 5 deletions docs/base-account/improve-ux/spend-permissions.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,8 @@ const permission = await fetchPermission({
try {
const { isActive, remainingSpend } = await getPermissionStatus(permission);
const amount = 1000n;

// Note: remainingSpend and amount are both in the token's smallest unit
// (e.g. for USDC with 6 decimals, 1_000_000n = $1.00)
if (!isActive || remainingSpend < amount) {
throw new Error("No spend permission available");
}
Expand All @@ -243,10 +244,8 @@ try {
}

// 3. prepare the calls
const [approveCall, spendCall] = await prepareSpendCallData({
permission,
amount,
});
const spendCalls = await prepareSpendCallData({ permission, amount });
calls: spendCalls

// 4. execute the calls using your app's spender account
// this is an example using wallet_sendCalls, in production it could be using eth_sendTransaction.
Expand Down