Correctly reference binaries on Windows#494
Open
kisabaka wants to merge 1 commit intobazelbuild:mainfrom
Open
Conversation
ted-xie
reviewed
May 7, 2026
| # Set reasonable max heap default. Required to prevent runaway memory usage. | ||
| # Can still be overridden by callers of this method. | ||
| jvm_flags = ["-Xms3G", "-Xmx3G", "-XX:+ExitOnOutOfMemoryError"] + jvm_flags | ||
| jvm_flags = ["-Xms512M", "-Xmx3G", "-XX:+ExitOnOutOfMemoryError"] + jvm_flags |
Contributor
There was a problem hiding this comment.
Please add a select for this if it's a specific Windows limitation.
Contributor
There was a problem hiding this comment.
Also, are you sure this is a problem for all Windows Android Java actions? We do have Windows Android builds running in BazelCI and I haven't seen any memory-related errors yet. Are you sure this isn't something wrong with your specific dev environment?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bazel buildfails to find the rightzipalignbinary on Windows because theselectinandroid_sdkis always falling back to the default branch. Apply the same fix that was applied toaapt2in #235Also reduce the initial JVM heap size as it causes a page size error on Windows (trying to allocate too much memory initially).