Skip to content

Install workflow deps from pyproject.toml dependency groups #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gwdio wants to merge 3 commits into from
Closed

Install workflow deps from pyproject.toml dependency groups #356

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5517c4b
Install workflow deps from pyproject.toml dependency groups
gwdio May 19, 2026
4a09337
Fix --group path to read deps from briefcase-template's pyproject.toml
gwdio May 19, 2026
49d6e24
Fix --group path to include pyproject.toml filename
gwdio May 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/app-create-verify.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,9 +87,11 @@ jobs:
**/pyproject.toml
.pre-commit-config.yaml

- name: Update pip
run: python -m pip install -U pip

- name: Install Dependencies
# must install before Briefcase below since requirements.txt contains an entry for Briefcase
run: python -m pip install -Ur ./briefcase-template/requirements.txt
run: python -m pip install --group './briefcase-template/pyproject.toml:test' --group './briefcase-template/pyproject.toml:dev'
Copy link
Copy Markdown
Member

@freakboy3742 freakboy3742 May 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL about the filename:group syntax for --group.

I think we might need to revisit the groupings in briefcase-template to make them a little more focussed. I think the set we need is:

  1. pre-commit (to run the pre-commit step on briefcase-template)
  2. tox (to run the unit-test step on briefcase-template)
  3. briefcase (as an explicit target for just briefcase, which is what app-create and app-build should need)
  4. test (the things needed to run the actual test suite - pytest, black, etc, including a link to the briefcase target)
  5. dev (for local development, linking essentially all of the above into a single target)


- name: Get Briefcase Package
# Briefcase will build and package itself in a previous step in its CI
Expand Down
Loading