Skip to content

Fix missing checks to enable beman-tidy with --require-all #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
teodor994 wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Fix missing checks to enable beman-tidy with --require-all #31

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
82c9306
Update files to solve missing or incorrect beman::cstring_view declar…
teodor994 Apr 25, 2026
979831b
Solved final declaration for cstring_view namespace
teodor994 Apr 25, 2026
b377c0d
updated namespace across the system
teodor994 Apr 25, 2026
27153a0
solved a bad namespace name
teodor994 Apr 25, 2026
a385a76
remove unnecessary changes
teodor994 Apr 25, 2026
3361207
Revert "remove unnecessary changes"
teodor994 Apr 25, 2026
82af7d3
updated README
teodor994 Apr 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ repos:
- repo: https://github.com/bemanproject/beman-tidy
rev: v0.3.1
hooks:
- id: beman-tidy
- id: beman-tidy
args: [".", "--verbose", "--require-all"]
Copy link
Copy Markdown
Member

@neatudarius neatudarius Apr 25, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Peter (@dascandy ), would you like to apply all RECOMMENDATIONS (actually only one left) and enabled --require-all in beman-tidy CI?

Context: During today's hackathon, as discussed in the meeting last Monday (and announced on discourse - https://discourse.bemanproject.org/t/heads-up-bemanification-event-saturday-april-25/575/2), we enabled beman-tidy in default mode on CI (it only checks for requirements; NOT recommendations).

My advice is to enabled --require-all, but as discussed with @bemanproject/project-leads , final decision is at library owners.

LE Also left similar suggestion on attached issue bemanproject/beman-tidy#252 (comment)


exclude: 'cookiecutter/|infra/'
6 changes: 3 additions & 3 deletions include/beman/cstring_view/cstring_view.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
#include <string_view>
#include <string>

namespace beman {
namespace beman::cstring_view {

#if !defined(USE_CPP17_VARIANT)
static_assert(__cpp_concepts >= 201907L);
Expand Down Expand Up @@ -81,7 +81,7 @@ constexpr wcstring_view operator""_csv(const wchar_t* str, size_t len) noexcep
#endif
} // namespace cstring_view_literals
} // namespace literals
} // namespace beman
} // namespace beman::cstring_view

namespace beman {

Expand Down Expand Up @@ -378,7 +378,7 @@ std::basic_ostream<charT, traits>& operator<<(std::basic_ostream<charT, traits>&
return os << std::basic_string_view<charT, traits>(str);
}

} // namespace beman
} // namespace beman::cstring_view
Comment thread
neatudarius marked this conversation as resolved.
Outdated

#if __cpp_lib_format >= 201907L
// [format.formatter.spec]
Expand Down
Loading