Beman.task migration utilities#275
Conversation
|
coverage: 95.409%. remained the same — JorgeV92:beman-task-migration into bemanproject:main |
dietmarkuehl
left a comment
dietmarkuehl
left a comment
There was a problem hiding this comment.
The changes are an improvement although there are some thing missing (as noted on the files directly). Also, I think the different components need to be modularized to eventually work when building modules. However, these changes can be made later.
| Allocator find_allocator() { | ||
| return Allocator(); | ||
| } |
There was a problem hiding this comment.
The flexible location of allocator_arg and allocator was removed as the last meeting before finalizing C++26: the allocator_arg and allocator are optionally the first arguments but they aren't taken from elsewhere.
| * \internal | ||
| */ | ||
| template <typename Base, std::size_t Size = 4u * sizeof(void*)> | ||
| class alignas(sizeof(double)) poly { |
There was a problem hiding this comment.
The poly class is actually too constrained: while a short buffer optimizition is reasonable, it should have a way to fallback to allocating more memory when needed.
3 participants
Added standalone detail utilities from beman.task into
execution/include/beman/execution/detail