Skip to content

Update Building in Ubuntu#680

Merged
haslinghuis merged 2 commits intobetaflight:masterfrom
haslinghuis:ubuntu-lts
May 4, 2026
Merged

Update Building in Ubuntu#680
haslinghuis merged 2 commits intobetaflight:masterfrom
haslinghuis:ubuntu-lts

Conversation

@haslinghuis
Copy link
Copy Markdown
Member

@haslinghuis haslinghuis commented May 2, 2026

  • Updated for latest Ubuntu 26.04 LTS
  • Use npm instead of yarn
  • Add additional DFU rules

Summary by CodeRabbit

Documentation

  • Updated Ubuntu build instructions to target Ubuntu 26.04 LTS.
  • Replaced build process with Node.js 24 LTS workflow using npm commands.
  • Updated local development server to localhost:8080.
  • Expanded USB DFU configuration with support for additional MCU device categories.
  • Improved formatting and minor wording refinements.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 2, 2026

Warning

Rate limit exceeded

@haslinghuis has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 20 minutes and 22 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: fae1fd58-f1ea-45c2-9705-844f63af17b5

📥 Commits

Reviewing files that changed from the base of the PR and between 499cf0f and d24c531.

📒 Files selected for processing (1)
  • docs/development/building/Building-in-Ubuntu.md

Walkthrough

Updated Ubuntu build documentation to target Ubuntu 26.04 LTS, modernized the Betaflight Configurator build workflow to use nvm with Node 24 LTS and npm scripts, updated local server instructions to point to http://localhost:8080/, and expanded USB DFU device support with additional vendor/product pairs.

Changes

Build Documentation Update

Layer / File(s) Summary
OS Target Update
docs/development/building/Building-in-Ubuntu.md
Ubuntu version target incremented from 24.04 LTS to 26.04 LTS.
Firmware Build Formatting
docs/development/building/Building-in-Ubuntu.md
EXTRA_FLAGS and DEBUG options are now formatted as explicit bullet points in the firmware rebuild section.
App Build Workflow
docs/development/building/Building-in-Ubuntu.md
Betaflight Configurator build instructions replaced with nvm-based Node.js 24 LTS workflow (npm install, npm run build, npm run dev); local server URL updated to http://localhost:8080/ with Ctrl+C to quit.
USB Configuration
docs/development/building/Building-in-Ubuntu.md
USB DFU udev rule block expanded with additional vendor/product ID pairs for extended MCU device support; post-setup wording updated from "active" to "activate".

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Update Building in Ubuntu' is vague and generic, using non-descriptive language that doesn't convey the specific nature of the changes. Consider a more specific title like 'Update Ubuntu build instructions for 26.04 LTS and npm workflow' to clearly indicate the main changes.
✅ Passed checks (4 passed)
Check name Status Explanation
Description check ✅ Passed The description is related to the changeset, listing key updates including Ubuntu 26.04 LTS upgrade, npm adoption, and DFU rules expansion.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 20 minutes and 22 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@docs/development/building/Building-in-Ubuntu.md`:
- Around line 55-60: The docs call out a non-existent script "npm run dev",
which will fail because the repo exposes "start" and "build" in package.json;
update the instruction in Building-in-Ubuntu.md to reference the actual script
(e.g., "npm start" or the correct script name used by the repo) and adjust the
surrounding text to say "Run npm start to launch the local server" so the
subsequent guidance about visiting http://localhost:8080/ and quitting with
Ctrl+C applies correctly.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 29ff7983-462c-4f8d-b726-7bae5b8e0867

📥 Commits

Reviewing files that changed from the base of the PR and between 31d2c8d and 499cf0f.

📒 Files selected for processing (1)
  • docs/development/building/Building-in-Ubuntu.md

Comment thread docs/development/building/Building-in-Ubuntu.md
coderabbitai[bot]
coderabbitai Bot previously approved these changes May 2, 2026
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 2, 2026

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 2, 2026

Preview URL: https://pr680.betaflight-com.pages.dev

@haslinghuis
Copy link
Copy Markdown
Member Author

@coderabbitai - full review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 2, 2026

Tip

For best results, initiate chat on the files or code changes.

@haslinghuis Sure! I'll kick off a full review of PR #680 right away.

[full_review]

@haslinghuis
Copy link
Copy Markdown
Member Author

@coderabbitai approve

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 2, 2026

✅ Actions performed

Comments resolved and changes approved.

@haslinghuis haslinghuis merged commit 86faa81 into betaflight:master May 4, 2026
9 checks passed
@haslinghuis haslinghuis deleted the ubuntu-lts branch May 4, 2026 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants