Skip to content

SSH test are not bound to host env variables #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zaratan wants to merge 3 commits into
base: master
Choose a base branch
from
Open

SSH test are not bound to host env variables #125

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
99d308c
SSH test are not bound to host env variables
zaratan Apr 20, 2021
4b1862c
standardrb --fix
zaratan Apr 20, 2021
c726424
Merge branch 'master' into fixing_ssh_tests
zaratan Jul 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions spec/lib/dip/commands/ssh_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@
describe Dip::Commands::SSH do
let(:cli) { Dip::CLI::SSH }

describe Dip::Commands::SSH::Up do
context "when without arguments", env: true do
let(:env) { {"HOME" => "/user"} }
describe Dip::Commands::SSH::Up, env: true do
let(:env) { {"HOME" => "/user"} }

context "when without arguments" do
before { cli.start "up".shellsplit }

it { expected_subprocess("docker", "volume create --name ssh_data") }
Expand All @@ -25,15 +25,15 @@
before { cli.start "up --key /foo/bar-baz-rsa".shellsplit }
it {
expected_subprocess("docker",
"run --rm --volume ssh_data:/ssh --volume /root:/root --interactive --tty whilp/ssh-agent ssh-add /foo/bar-baz-rsa")
"run --rm --volume ssh_data:/ssh --volume /user:/user --interactive --tty whilp/ssh-agent ssh-add /foo/bar-baz-rsa")
}
end

context "when option `volume` is present" do
before { cli.start "up --volume /foo/.ssh".shellsplit }
it {
expected_subprocess("docker",
"run --rm --volume ssh_data:/ssh --volume /foo/.ssh:/foo/.ssh --interactive --tty whilp/ssh-agent ssh-add /root/.ssh/id_rsa")
"run --rm --volume ssh_data:/ssh --volume /foo/.ssh:/foo/.ssh --interactive --tty whilp/ssh-agent ssh-add /user/.ssh/id_rsa")
}
end

Expand Down