Skip to content

Implement ListSessions of BGP API#271

Open
sebageek wants to merge 2 commits into
bio-routing:masterfrom
sebageek:bgp-api-implement-listsessions
Open

Implement ListSessions of BGP API#271
sebageek wants to merge 2 commits into
bio-routing:masterfrom
sebageek:bgp-api-implement-listsessions

Conversation

@sebageek

Copy link
Copy Markdown
Contributor

VRF filtering and some session stats are still missing here, but listing
sessions does work.


I'm not 100% on what I should fill in into the SessionStat, that's why I only filled them partly.

@codecov-commenter

codecov-commenter commented May 23, 2020

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.48936% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.60%. Comparing base (52c6591) to head (855dbd4).
⚠️ Report is 265 commits behind head on master.

Files with missing lines Patch % Lines
protocols/bgp/server/bgp_api.go 91.48% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #271      +/-   ##
==========================================
+ Coverage   59.25%   59.60%   +0.35%     
==========================================
  Files         137      137              
  Lines        7542     7588      +46     
==========================================
+ Hits         4469     4523      +54     
+ Misses       2892     2882      -10     
- Partials      181      183       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sebageek

Copy link
Copy Markdown
Contributor Author

From a quick look it should also be easy to get RoutesImported and RoutesExported from the metrics service. I'll add this to this PR tomorrow.

@sebageek sebageek marked this pull request as draft May 24, 2020 01:53
@sebageek sebageek force-pushed the bgp-api-implement-listsessions branch 2 times, most recently from 7f74a99 to a1a2d12 Compare May 24, 2020 02:23
@sebageek sebageek marked this pull request as ready for review May 24, 2020 02:23
@sebageek sebageek force-pushed the bgp-api-implement-listsessions branch from a1a2d12 to c866150 Compare May 24, 2020 13:14
sebageek added 2 commits May 27, 2020 00:53
flaps + routes imported in the stats are still missing.
@sebageek sebageek force-pushed the bgp-api-implement-listsessions branch from c866150 to 855dbd4 Compare May 26, 2020 23:22
@sebageek

Copy link
Copy Markdown
Contributor Author

I added some stuff. The session API now has a vrf_name field, the description field is filled and vrf_name filtering is implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants