Skip to content

Fix merge key order, clear anchors after resolving#506

Merged
biojppm merged 4 commits intomasterfrom
fix/merge_key_order
Mar 25, 2025
Merged

Fix merge key order, clear anchors after resolving#506
biojppm merged 4 commits intomasterfrom
fix/merge_key_order

Conversation

@biojppm
Copy link
Copy Markdown
Owner

@biojppm biojppm commented Mar 25, 2025

Fixes #484
Fixes #400

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 25, 2025

Codecov Report

Attention: Patch coverage is 94.68085% with 5 lines in your changes missing coverage. Please review.

Project coverage is 97.37%. Comparing base (d3132a2) to head (5f1bcee).
Report is 19 commits behind head on master.

Files with missing lines Patch % Lines
src/c4/yml/tree.cpp 92.30% 3 Missing ⚠️
src/c4/yml/reference_resolver.cpp 96.15% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #506      +/-   ##
==========================================
- Coverage   97.37%   97.37%   -0.01%     
==========================================
  Files          34       34              
  Lines       11472    11507      +35     
==========================================
+ Hits        11171    11205      +34     
- Misses        301      302       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coveralls
Copy link
Copy Markdown

coveralls commented Mar 25, 2025

Pull Request Test Coverage Report for Build 14069134494

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 60 of 60 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 97.578%

Totals Coverage Status
Change from base Build 14022406418: 0.05%
Covered Lines: 11564
Relevant Lines: 11851

💛 - Coveralls

@biojppm biojppm force-pushed the fix/merge_key_order branch from df77dc4 to a735df9 Compare March 25, 2025 15:00
@biojppm biojppm force-pushed the fix/merge_key_order branch from a735df9 to 5f1bcee Compare March 25, 2025 20:09
@biojppm
Copy link
Copy Markdown
Owner Author

biojppm commented Mar 25, 2025

The coverage downgrade is likely spurious; merging now.

@biojppm biojppm merged commit fa8aebb into master Mar 25, 2025
257 of 258 checks passed
@biojppm biojppm deleted the fix/merge_key_order branch March 25, 2025 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Merge key order Tree::resolve() leaves some references in place in certain cases

2 participants