Swap std::is_trivial with non deprecated traits#541
Merged
biojppm merged 2 commits intobiojppm:masterfrom Sep 16, 2025
Merged
Conversation
469b2f1 to
f8e8c99
Compare
biojppm
requested changes
Sep 6, 2025
f8e8c99 to
c5a586a
Compare
Contributor
Author
|
Hey @biojppm, sorry for being unresponsive! Let me know how do you want me to proceed. |
Owner
|
Please split. |
Split the triviality check due to clang_tidy warning
biojppm
approved these changes
Sep 15, 2025
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves the deprecation warning triggered by the use of
std::is_trivial<LineCol>in RapidYAML headers when building on C++26 standard.Warning Details
During build, the following warning was emitted:
On line:
static_assert(std::is_trivial<LineCol>::value, "LineCol not trivial");Notes