Rework memory pressure system#261
Open
kwsantiago wants to merge 5 commits into
Open
Conversation
Ari4ka
approved these changes
Feb 17, 2026
There was a problem hiding this comment.
Pull request overview
Reworks the node’s memory-pressure handling to trigger cache flushes more reliably (including during idle periods) and to reserve flush headroom for LevelDB allocations, addressing edge cases described in #216.
Changes:
- Reserve a fixed “flush headroom” in coins cache sizing to avoid running out of allocatable space during LevelDB batch writes.
- Add a cross-platform
GetAvailableSystemMemory()helper and updateSystemNeedsMemoryReleased()to use it. - Change
-lowmemdefaults (200 MiB on Linux/Windows) and add a periodic idle scheduler task to flush caches when memory pressure is detected.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
src/validation.cpp |
Reserves LevelDB flush headroom in cache sizing; integrates memory-pressure signal into flush decision and cache-emptying behavior. |
src/util/mempressure.h |
Exposes new available-memory query helper. |
src/util/mempressure.cpp |
Implements GetAvailableSystemMemory() and updates memory-pressure detection logic. |
src/init.cpp |
Updates -lowmem defaults/validation and adds periodic idle memory-pressure flushing via scheduler. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
l0rinc
reviewed
Mar 19, 2026
Ari4ka
approved these changes
Mar 19, 2026
Ari4ka
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #216