Remove BBOTTarget pickle support

The HTTP engine subprocess that consumed pickled targets is gone — blasthttp
runs in-process. Drop BaseTarget.__getstate__/__setstate__, ScanBlacklist.__setstate__,
and the test_target_pickle round-trip test.

Author: liquidsec

bbot/scanner/target.py

@@ -178,18 +178,6 @@ def __len__(self):
     def __bool__(self):
         return bool(len(self._rt)) or bool(self.event_seeds)
 
-    def __getstate__(self):
-        """Serialize for pickling — RadixTarget (PyO3) can't be pickled directly."""
-        return {
-            "inputs": [str(e.input) for e in self.event_seeds],
-            "strict_scope": self.strict_scope,
-            "acl_mode": getattr(self._rt, "_acl_mode", False),
-        }
-
-    def __setstate__(self, state):
-        """Reconstruct from pickled state."""
-        self.__init__(*state["inputs"], strict_scope=state["strict_scope"], acl_mode=state.get("acl_mode", False))
-
     def __eq__(self, other):
         return self.hash == getattr(other, "hash", None)
 
@@ -266,10 +254,6 @@ def __init__(self, *args, **kwargs):
         self.blacklist_regexes = set()
         super().__init__(*args, **kwargs)
 
-    def __setstate__(self, state):
-        self.blacklist_regexes = set()
-        super().__setstate__(state)
-
     def get(self, host, **kwargs):
         """
         Blacklists only accept IPs or strings. This is cleaner since we need to search for regex patterns.

bbot/test/test_step_1/test_target.py

@@ -703,36 +703,6 @@ def counting_EventSeed(input):
     )
 
 
-def test_target_pickle():
-    """BBOTTarget must survive pickle round-trips (used by HTTP engine subprocess)."""
-    import pickle
-
-    from bbot.scanner.target import BBOTTarget
-
-    target = BBOTTarget(
-        target=["evilcorp.com", "1.2.3.0/24"],
-        blacklist=["bad.evilcorp.com"],
-        strict_scope=False,
-    )
-
-    data = pickle.dumps(target)
-    restored = pickle.loads(data)
-
-    # scope checks work after unpickling
-    assert restored.in_target("evilcorp.com")
-    assert restored.in_target("www.evilcorp.com")
-    assert restored.in_target("1.2.3.4")
-    assert not restored.in_target("9.9.9.9")
-
-    # blacklist works after unpickling
-    assert restored.blacklisted("bad.evilcorp.com")
-    assert not restored.in_scope("bad.evilcorp.com")
-    assert restored.in_scope("good.evilcorp.com")
-
-    # hashes match
-    assert target.hash == restored.hash
-
-
 def test_target_comments():
     """Target strings support # comments — both full-line and inline."""
     from bbot.scanner.target import BBOTTarget