Lib: Further reduce dependency list#767
Merged
Merged
Conversation
hydra-yse
force-pushed
the
yse-reduce-deps
branch
2 times, most recently
from
56ca5e5 to
3e126e5
Compare
hydra-yse
requested review from
JssDWt,
dangeross,
danielgranhao,
roeierez and
yaslama
hydra-yse
force-pushed
the
yse-reduce-deps
branch
3 times, most recently
from
57e5b2b to
c7d8619
Compare
JssDWt
reviewed
Apr 3, 2026
Collaborator
JssDWt
left a comment
JssDWt
left a comment
There was a problem hiding this comment.
Looking good. I need one more look at the ecies implementation.
Member
|
@hydra-yse other than the postgres tls testing and breez temporary fork LGTM. ping again when these are fixed. |
rayon was declared in [workspace.dependencies] but had zero usages anywhere in the workspace. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
openssl was a vestigial dep from the reqwest → bitreq migration: commit 802178b changed `openssl-vendored = ["reqwest/native-tls-vendored"]` to a direct openssl dep, then 9a67d15 removed reqwest but left openssl behind. It was never called from Rust code — only linked via the `uniffi` feature chain. rustls already covers all TLS needs. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
strum / strum_macros were used solely to derive Display on BitcoinNetwork in one file. Replace with a five-arm match impl. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
enum_to_enum was used on two enums in graphql/models.rs to generate From impls across seven source types. Replace with a local macro for the unit-variant conversions and an explicit impl for SspUserRequest. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
jwt was used solely to extract the `exp` claim from the flashnet access token to compute cache TTL. Replace with: split on '.', decode the payload segment with base64url (URL_SAFE_NO_PAD), deserialize the JSON, and extract the `exp` field. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
serde_qs was used only in flashnet's get_request_inner to serialize flat query structs. serde_urlencoded (already a transitive dep via reqwest) handles repeated keys for Vec fields identically to serde_qs Unindexed format, which is all this code requires. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
x509-cert (RustCrypto) v0.2.5 was already in the dep tree via tokio-postgres-rustls. Replacing x509-parser removes 7 exclusive crates: nom, asn1-rs, asn1-rs-derive, asn1-rs-impl, der-parser, oid-registry, rusticata-macros. Also removes the unused rayon reference from xtask/Cargo.toml. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This switches to a custom fork of rustls until rust-bitcoin/corepc#536 is merged
Swaps the heavyweight `regex` crate (which pulls in full Unicode property tables) for `regex-lite`, which has an identical API but restricts patterns to ASCII/basic Unicode — sufficient for all ExternalInputParser use cases. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
hydra-yse
force-pushed
the
yse-reduce-deps
branch
from
96bb148 to
626ef80
Compare
Member
Author
|
Tested postgres with Supabase via breez-cli, and it works! If not enough we can update Postgres support on Glow and we can also test from mobile, but I've already tested other rustls features there those work as well |
roeierez
approved these changes
Apr 7, 2026
Member
roeierez
left a comment
roeierez
left a comment
There was a problem hiding this comment.
LGTM given the integration tests will pass.
erdemyerebasmaz
pushed a commit
that referenced
this pull request
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #497.
This PR removes:
rayonopensslstrum/strum_macrosenum_to_enumjwtserde_qsx509-parser->x509-certregex->regex-liteeciesTO-DOs
openssldep on older Android environments (Edit: Tested on Android 13)getrandom)