Skip to content

fix: friendly error when registering a node with a duplicate name #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
theFong merged 3 commits into from
Jun 26, 2026
+7 −0
Merged

fix: friendly error when registering a node with a duplicate name #413

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
96e8241
fix: friendly error when registering a node with a duplicate name
theFong Jun 24, 2026
eacfad0
fix: also match connect AlreadyExists code for duplicate node name
theFong Jun 24, 2026
ed9dd32
fix: drop backwards-compat string match, surface server message for d…
theFong Jun 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions pkg/cmd/register/register.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package register

import (
"context"
"errors"
"fmt"
"os/user"
"strings"
Expand Down Expand Up @@ -292,6 +293,12 @@ func runRegisterSteps(ctx context.Context, t *terminal.Terminal, s RegisterStore
NodeSpec: toProtoNodeSpec(hwProfile),
}))
if err != nil {
// dev-plane returns CodeAlreadyExists for a duplicate node name; surface
// its message directly, which already reads as "node already exists".
var connectErr *connect.Error
if errors.As(err, &connectErr) && connectErr.Code() == connect.CodeAlreadyExists {
return nil, errors.New(connectErr.Message())
}
return nil, fmt.Errorf("failed to register node: %w", err)
}

Expand Down
Loading