Add browser manager and explicit browser selection by gregpr07 · Pull Request #454 · browser-use/browser-harness

gregpr07 · 2026-06-18T06:32:59Z

Summary by cubic

Adds manager mode with explicit browser ids and isolated runtimes: create with browser_new("private" | "cloud"), then select with browser(id) before using page helpers. Also adds PyPI packaging with uv install, a browser-harness skill command, XDG-based workspace paths, cloud auth login/import with leaner status, a repo-local ./browser-harness launcher, tighter diagnostics and JS evaluation, and opt‑out telemetry.

New Features
- Manager daemon/client manage create/list/switch/close across isolated runtime/tmp/download/artifact dirs with safe cleanup; multiple clients can select the same browser via an active binding context.
- Local profiles: browser_profiles([verbose]) lists stable ids (e.g. google-chrome:Default), browser_use_profile(id) selects one; the CLI subcommand browser-harness profiles [--verbose] runs without starting the daemon.
- Cloud auth: auth login/status/logout/import using OAuth PKCE, device code, or safe stdin key import; prefers BROWSER_USE_API_KEY, otherwise stores a scoped key under BH_AUTH_PATH; cloud responses include a live_url when available; status output trimmed to essentials.
- Packaging and install: published to PyPI with a release workflow; install via uv tool install browser-harness; browser-harness skill prints the canonical skill body; materializes SKILL.md in packages for non-symlink installs; new docs/browser-connection.md; shorter install guide.
- Filesystem: default workspace and runtime live under ${XDG_CONFIG_HOME:-~/.config}/browser-harness/; override with BH_HOME, BH_CONFIG_DIR, or BH_RUNTIME_DIR; manager endpoint via BH_MANAGER_ROOT/BH_MANAGER_SOCKET.
- Dev experience: repo-local ./browser-harness launcher runs the working tree without a venv and uses a checkout-specific manager root under /tmp; new browser-harness-manager entrypoint.
- Reliability: JS helpers retry only on CDP “Illegal return statement”; press_key no longer emits a stray char with modifiers; treat explicit BU_CDP_URL as remote; clearer Chrome permission popup guidance; manager mode skips legacy daemon auto-start.
- Telemetry: low-cardinality, best-effort, opt-out telemetry; disable with BH_TELEMETRY=0 or BROWSER_HARNESS_TELEMETRY=0.
Migration
- Update scripts to browser_new("private" | "cloud") → keep the returned id → browser(id) before page helpers.
- Replace list_local_profiles() with browser_profiles() and use_local_profile(id) with browser_use_profile(id).
- Workspace paths now default to ${XDG_CONFIG_HOME:-~/.config}/browser-harness/agent-workspace/; adjust any hard-coded references or set BH_CONFIG_DIR/BH_HOME.
- Remote CDP flows are unchanged; set BU_CDP_WS or BU_CDP_URL to use a specific endpoint.
- For cloud browsers, set BROWSER_USE_API_KEY, run browser-harness auth login (supports device code and stdin), or browser-harness auth import once.

^{Written for commit 07e56f7. Summary will update on new commits.}

browser-harness-review · 2026-06-18T06:33:14Z

⛔ Skill review blocked

An automated security review found 1 finding(s) across 1 file(s).

interaction-skills/profile-sync.md — malicious_code

Skill authorship is restricted to maintainers. Please do not attempt to self-fix — a maintainer will review and follow up.

cubic-dev-ai

1 issue found across 5 files (changes from recent commits).

Prompt for AI agents (unresolved issues)


Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="src/browser_harness/auth.py">

<violation number="1" location="src/browser_harness/auth.py:457">
P2: TTY API-key entry can crash on aborted input because `EOFError` from `getpass` is not handled. Convert prompt failures to `AuthError` so CLI exits cleanly with error status.</violation>
</file>

_{Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic}

cubic-dev-ai

6 issues found and verified against the latest diff

Prompt for AI agents (unresolved issues)


Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="tests/unit/test_run_manager_mode.py">

<violation number="1" location="tests/unit/test_run_manager_mode.py:42">
P2: All three tests leak BH_MANAGER_MODE into os.environ — run.main() calls setdefault('BH_MANAGER_MODE', '1') but no test cleans it up. Can cause test-order-dependent failures in any test that reads BH_MANAGER_MODE.</violation>
</file>

_{Tip: instead of fixing issues one by one fix them all with cubic

Re-trigger cubic}

cubic-dev-ai

4 issues found across 34 files (changes from recent commits).

Prompt for AI agents (unresolved issues)


Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name=".github/workflows/release.yml">

<violation number="1" location=".github/workflows/release.yml:16">
P1: Release workflow uses mutable action tags instead of immutable commit SHAs, creating CI/CD supply-chain risk for PyPI publishing.</violation>
</file>

<file name="install.md">

<violation number="1" location="install.md:14">
P2: Install instructions use unconditional `rm -rf` on generic skill directory names, risking deletion of legitimate user skills</violation>
</file>

<file name="src/browser_harness/manager_client.py">

<violation number="1" location="src/browser_harness/manager_client.py:97">
P2: `stop_manager_if_running` ignores the response from `send_request` and unconditionally returns `True` on successful transport, misleading callers if the daemon rejects shutdown.</violation>
</file>

<file name="src/browser_harness/local_profiles.py">

<violation number="1" location="src/browser_harness/local_profiles.py:86">
P2: Changing profile_config_path() to return settings.json risks silent data loss because set_default_profile_id() overwrites the entire file without reading existing content. The docs describe settings.json as "selected local Chrome profile and future preferences", indicating it is a shared settings document. Future preferences stored there will be clobbered on every profile change.</violation>
</file>

_{Tip: Review your code locally with the cubic CLI to iterate faster.

Fix all with cubic | Re-trigger cubic}

cubic-dev-ai · 2026-06-21T00:26:19Z

+      contents: read
+      id-token: write
+    steps:
+      - uses: actions/checkout@v4


P1: Release workflow uses mutable action tags instead of immutable commit SHAs, creating CI/CD supply-chain risk for PyPI publishing.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At .github/workflows/release.yml, line 16: <comment>Release workflow uses mutable action tags instead of immutable commit SHAs, creating CI/CD supply-chain risk for PyPI publishing.</comment> <file context> @@ -0,0 +1,25 @@ + contents: read + id-token: write + steps: + - uses: actions/checkout@v4 + - uses: actions/setup-python@v5 + with: </file context>

cubic-dev-ai · 2026-06-21T00:26:19Z

-uv tool install -e .
-command -v browser-harness
+uv tool install browser-harness
+for root in "${CODEX_HOME:-$HOME/.codex}/skills" "$HOME/.agents/skills"; do


P2: Install instructions use unconditional rm -rf on generic skill directory names, risking deletion of legitimate user skills

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At install.md, line 14: <comment>Install instructions use unconditional `rm -rf` on generic skill directory names, risking deletion of legitimate user skills</comment> <file context> @@ -1,176 +1,79 @@ -uv tool install -e . -command -v browser-harness +uv tool install browser-harness +for root in "${CODEX_HOME:-$HOME/.codex}/skills" "$HOME/.agents/skills"; do + rm -rf "$root/browser-harness" "$root/browser" "$root/browser-use" +done </file context>

cubic-dev-ai · 2026-06-21T00:26:19Z

+    except (FileNotFoundError, ConnectionRefusedError, TimeoutError, OSError, ValueError, KeyError, TypeError):
+        return False
+    try:
+        manager_runtime.send_request(sock, token, {"meta": "shutdown"})


P2: stop_manager_if_running ignores the response from send_request and unconditionally returns True on successful transport, misleading callers if the daemon rejects shutdown.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At src/browser_harness/manager_client.py, line 97: <comment>`stop_manager_if_running` ignores the response from `send_request` and unconditionally returns `True` on successful transport, misleading callers if the daemon rejects shutdown.</comment> <file context> @@ -87,6 +87,24 @@ def _manager_socket_alive(path: Path) -> bool: + except (FileNotFoundError, ConnectionRefusedError, TimeoutError, OSError, ValueError, KeyError, TypeError): + return False + try: + manager_runtime.send_request(sock, token, {"meta": "shutdown"}) + return True + except (OSError, ValueError, AttributeError): </file context>

cubic-dev-ai · 2026-06-21T00:26:19Z

+
+
+def profile_config_path() -> Path:
+    return config_dir() / "settings.json"


P2: Changing profile_config_path() to return settings.json risks silent data loss because set_default_profile_id() overwrites the entire file without reading existing content. The docs describe settings.json as "selected local Chrome profile and future preferences", indicating it is a shared settings document. Future preferences stored there will be clobbered on every profile change.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At src/browser_harness/local_profiles.py, line 86: <comment>Changing profile_config_path() to return settings.json risks silent data loss because set_default_profile_id() overwrites the entire file without reading existing content. The docs describe settings.json as "selected local Chrome profile and future preferences", indicating it is a shared settings document. Future preferences stored there will be clobbered on every profile change.</comment> <file context> @@ -77,18 +79,14 @@ def payload(self) -> dict: def profile_config_path() -> Path: + return config_dir() / "settings.json" + + </file context>

gregpr07 added 3 commits June 17, 2026 23:21

Add Python browser manager

2f3ac28

Add Browser Use cloud auth login

dffcca0

Add local profile targeting and browser cleanup

73743ed

github-advanced-security AI found potential problems Jun 18, 2026

View reviewed changes

Comment thread src/browser_harness/auth.py Fixed

Comment thread src/browser_harness/auth.py Fixed

Comment thread src/browser_harness/auth.py Fixed

Add safe manual Browser Use key import

e573f5d

github-advanced-security AI found potential problems Jun 18, 2026

View reviewed changes

Comment thread src/browser_harness/auth.py Fixed

cubic-dev-ai Bot reviewed Jun 18, 2026

View reviewed changes

Comment thread src/browser_harness/auth.py Outdated

cubic-dev-ai Bot reviewed Jun 18, 2026

View reviewed changes

gregpr07 added 8 commits June 18, 2026 09:02

Simplify LLM browser interface

2aaca8b

Make managed browser selection explicit

8281995

Add repo-local browser-harness dev launcher

2571d25

Simplify shared browser manager semantics

2e8613e

Harden browser manager runtime

ded09ca

Tighten harness setup diagnostics

07ea791

Clean up browser manager PR edge cases

cc2dbc2

Reduce auth status output surface

64af337

gregpr07 changed the title ~~Codex/browser manager impl~~ Add browser manager and explicit browser selection Jun 19, 2026

gregpr07 added 3 commits June 20, 2026 17:14

Prepare browser-harness package releases

134e7fe

Shorten browser-harness install guide

0cf772b

Remove branch test churn

07e56f7

cubic-dev-ai Bot reviewed Jun 21, 2026

View reviewed changes



		def profile_config_path() -> Path:
		return config_dir() / "settings.json"

Conversation

gregpr07 commented Jun 18, 2026 • edited by cubic-dev-ai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by cubic

Uh oh!

browser-harness-review Bot commented Jun 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⛔ Skill review blocked

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai Bot Jun 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai Bot Jun 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai Bot Jun 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai Bot Jun 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

gregpr07 commented Jun 18, 2026 •

edited by cubic-dev-ai Bot

Loading

browser-harness-review Bot commented Jun 18, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

cubic-dev-ai Bot Jun 21, 2026 •

edited

Loading

cubic-dev-ai Bot Jun 21, 2026 •

edited

Loading

cubic-dev-ai Bot Jun 21, 2026 •

edited

Loading

cubic-dev-ai Bot Jun 21, 2026 •

edited

Loading