Skip to content

Add BH_NO_ACTIVATE to stop new_tab/switch_tab from stealing OS focus #469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aiba wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −3
Open

Add BH_NO_ACTIVATE to stop new_tab/switch_tab from stealing OS focus #469

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/browser_harness/daemon.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,10 @@ async def attach_first_page(self):
pages = [t for t in targets if is_real_page(t)]
if not pages:
# No real pages — create one instead of attaching to omnibox popup
tid = (await self.cdp.send_raw("Target.createTarget", {"url": "about:blank"}))["targetId"]
create_params = {"url": "about:blank"}
if os.environ.get("BH_NO_ACTIVATE") == "1":
create_params["background"] = True # Mac-only: don't raise the window.
tid = (await self.cdp.send_raw("Target.createTarget", create_params))["targetId"]
log(f"no real pages found, created about:blank ({tid})")
pages = [{"targetId": tid, "url": "about:blank", "type": "page"}]
self.session = (await self.cdp.send_raw(
Expand Down
11 changes: 9 additions & 2 deletions src/browser_harness/helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,11 @@ def switch_tab(target):
# plus the trailing space = 3 code units, so slice(3) cleanly removes the prefix.
try: cdp("Runtime.evaluate", expression="if(document.title.startsWith('\U0001F434 '))document.title=document.title.slice(3)")
except Exception: pass
cdp("Target.activateTarget", targetId=target_id)
# Target.activateTarget raises and focuses the OS window on macOS, stealing
# focus from whatever the user is typing in. Skip it when BH_NO_ACTIVATE=1;
# the horse-emoji title still marks which tab the agent controls.
if os.environ.get("BH_NO_ACTIVATE") != "1":
cdp("Target.activateTarget", targetId=target_id)
sid = cdp("Target.attachToTarget", targetId=target_id, flatten=True)["sessionId"]
_send({"meta": "set_session", "session_id": sid, "target_id": target_id})
_mark_tab()
Expand All @@ -318,7 +322,10 @@ def new_tab(url="about:blank"):
# Always create blank, then goto: passing url to createTarget races with
# attach, so the brief about:blank is "complete" by the time the caller
# polls and wait_for_load() returns before navigation actually starts.
tid = cdp("Target.createTarget", url="about:blank")["targetId"]
params = {"url": "about:blank"}
if os.environ.get("BH_NO_ACTIVATE") == "1":
params["background"] = True # Mac-only: open the tab without raising the window.
tid = cdp("Target.createTarget", **params)["targetId"]
switch_tab(tid)
if url != "about:blank":
goto_url(url)
Expand Down