Pri/plat 15991 rnnvu nc#2741
Open
SB-priyankap wants to merge 3 commits intonextfrom
Open
Conversation
SB-priyankap
requested review from
SB-gulshans,
SB-jigneshR,
hamudi-ahmed and
sb-gaurava
| limit: 1 | ||
|
|
||
| - label: ':android: Build react-native-navigation {{matrix}} test fixture APK (New Arch)' | ||
| skip: true # Skipped pending PLAT-15027 |
Contributor
There was a problem hiding this comment.
We are no longer skipping the test so this line should be deleted not just commented out
| - "0.72" | ||
|
|
||
| - label: ":bitbar: :android: react-native-navigation {{matrix}} Android 12 (New Arch) end-to-end tests" | ||
| skip: true # Skipped pending PLAT-15027 |
Contributor
There was a problem hiding this comment.
Same here - just delete the line instead of commenting out
|
|
||
| const REACT_NATIVE_NAVIGATION_PEER_DEPENDENCIES = [ | ||
| 'react-native-navigation@7.41.0' // Issue with 7.42.0 | ||
| 'react-native-navigation@8.5.0' // Issue with 7.42.0 |
Contributor
There was a problem hiding this comment.
Suggested change
| 'react-native-navigation@8.5.0' // Issue with 7.42.0 | |
| 'react-native-navigation@8.5.0' |
This comment is no longer relevant so should probably be removed to avoid confusion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Update react-native-navigation version
Changeset
changes in yml file and script file
Testing
did end to end testing and run unit test cases