Skip to content

annotation: make GeneratedAppGlideModuleImpl public to fix Kotlin 2.2.20 visibility warning (#5601) #5660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iVamsi wants to merge 2 commits into
base: master
Choose a base branch
from
Open

annotation: make GeneratedAppGlideModuleImpl public to fix Kotlin 2.2.20 visibility warning (#5601) #5660

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d0d3fbb
annotation: make GeneratedAppGlideModuleImpl public to fix Kotlin 2.2…
iVamsi Mar 1, 2026
03abb98
Merge branch 'master' into fix/generated-module-visibility-5601
iVamsi Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...ion/compiler/src/main/java/com/bumptech/glide/annotation/compiler/AppModuleGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
*
* <pre>
* <code>
* final class GeneratedAppGlideModuleImpl extends com.bumptech.glide.GeneratedAppGlideModule {
* public final class GeneratedAppGlideModuleImpl extends com.bumptech.glide.GeneratedAppGlideModule {
* private final com.bumptech.glide.samples.giphy.GiphyGlideModule appGlideModule;
*
* GeneratedAppGlideModule() {
Expand Down Expand Up @@ -141,7 +141,7 @@ TypeSpec generate(TypeElement appGlideModule, Set<String> libraryGlideModuleClas

Builder builder =
TypeSpec.classBuilder(GENERATED_APP_MODULE_IMPL_SIMPLE_NAME)
.addModifiers(Modifier.FINAL)
.addModifiers(Modifier.PUBLIC, Modifier.FINAL)
.addAnnotation(
AnnotationSpec.builder(SuppressWarnings.class)
.addMember("value", "$S", "deprecation")
Expand Down
2 changes: 1 addition & 1 deletion ...r/test/src/test/resources/AppGlideModuleWithExcludesTest/GeneratedAppGlideModuleImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
import java.util.Set;

@SuppressWarnings("deprecation")
final class GeneratedAppGlideModuleImpl extends GeneratedAppGlideModule {
public final class GeneratedAppGlideModuleImpl extends GeneratedAppGlideModule {
private final AppModuleWithExcludes appGlideModule;

public GeneratedAppGlideModuleImpl(Context context) {
Expand Down
2 changes: 1 addition & 1 deletion ...rc/test/resources/AppGlideModuleWithLibraryInPackageTest/GeneratedAppGlideModuleImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
import java.util.Set;

@SuppressWarnings("deprecation")
final class GeneratedAppGlideModuleImpl extends GeneratedAppGlideModule {
public final class GeneratedAppGlideModuleImpl extends GeneratedAppGlideModule {
private final AppModuleWithLibraryInPackage appGlideModule;

public GeneratedAppGlideModuleImpl(Context context) {
Expand Down
2 changes: 1 addition & 1 deletion ...rc/test/resources/AppGlideModuleWithMultipleExcludesTest/GeneratedAppGlideModuleImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
import java.util.Set;

@SuppressWarnings("deprecation")
final class GeneratedAppGlideModuleImpl extends GeneratedAppGlideModule {
public final class GeneratedAppGlideModuleImpl extends GeneratedAppGlideModule {
private final AppModuleWithMultipleExcludes appGlideModule;

public GeneratedAppGlideModuleImpl(Context context) {
Expand Down
2 changes: 1 addition & 1 deletion ...st/src/test/resources/EmptyAppAndLibraryGlideModulesTest/GeneratedAppGlideModuleImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
import java.util.Set;

@SuppressWarnings("deprecation")
final class GeneratedAppGlideModuleImpl extends GeneratedAppGlideModule {
public final class GeneratedAppGlideModuleImpl extends GeneratedAppGlideModule {
private final EmptyAppModule appGlideModule;

public GeneratedAppGlideModuleImpl(Context context) {
Expand Down
2 changes: 1 addition & 1 deletion ...compiler/test/src/test/resources/EmptyAppGlideModuleTest/GeneratedAppGlideModuleImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
import java.util.Set;

@SuppressWarnings("deprecation")
final class GeneratedAppGlideModuleImpl extends GeneratedAppGlideModule {
public final class GeneratedAppGlideModuleImpl extends GeneratedAppGlideModule {
private final EmptyAppModule appGlideModule;

public GeneratedAppGlideModuleImpl(Context context) {
Expand Down
2 changes: 1 addition & 1 deletion library/src/main/java/com/bumptech/glide/GeneratedAppGlideModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
* processing system and optionally provides a {@link
* com.bumptech.glide.manager.RequestManagerRetriever.RequestManagerFactory} impl.
*/
abstract class GeneratedAppGlideModule extends AppGlideModule {
public abstract class GeneratedAppGlideModule extends AppGlideModule {
/** This method can be removed when manifest parsing is no longer supported. */
@NonNull
Set<Class<?>> getExcludedModuleClasses() {
Expand Down
Loading