chore: implement circuit breaker#6
Merged
d-bytebase merged 9 commits intomainfrom Oct 2, 2025
Merged
Conversation
d-bytebase
requested changes
Oct 2, 2025
d-bytebase
approved these changes
Oct 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
gh-ost's binlog syncer retries authentication failures indefinitely at 1-second intervals, causing retry storms with 800,000+ attempts that trigger enterprise firewall blocks and service disruptions.
Solution
Added circuit breaker that stops after MaxAuthFailures attempts (default: 10). The implementation tracks authentication failures using MySQL error codes (1045, 1130, etc.), stops the migration gracefully after the threshold, and resets the counter on successful connections. This reduces retry storms from hours/millions of attempts to ~10 seconds/10 attempts, preventing firewall blocks while maintaining backward compatibility when MaxAuthFailures=0.