feat(skills): add React Native deployment skill with Fastlane#59
Open
rudra-chothe wants to merge 1 commit intocallstackincubator:mainfrom
Open
feat(skills): add React Native deployment skill with Fastlane#59rudra-chothe wants to merge 1 commit intocallstackincubator:mainfrom
rudra-chothe wants to merge 1 commit intocallstackincubator:mainfrom
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 31dba2229a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new
deploymentskills category for React Native release engineering:Closes
Closes #28
Key Changes
New skill:
skills/deployment/SKILL.mdorchestrates the flow and includes the 16KB local prerequisite stepreferences/publish-checklist.mdadds an explicit Android 16KB blocker rule and links to:skills/react-native-best-practices/references/native-android-16kb-alignment.mdreferences/fastlane-deployment.mdincludes:workflow_dispatchinputs for Android track and iOS targetreferences/e2e-prepublish-tests.mdprovides gating guidance (Detox/Maestro etc.)Discoverability updates
README.md: adds thedeploymentskill to the available skills list + install command.claude-plugin/marketplace.json: registers the newdeploymentplugin entrySecrets Handling (security requirement)
Credentials are expected only via GitHub Actions repository secrets:
GOOGLE_PLAY_JSON_KEY_BASE64APP_STORE_CONNECT_API_KEY_BASE64(plus
APP_STORE_CONNECT_KEY_ID,APP_STORE_CONNECT_ISSUER_IDwhen using the API-key Appfile path)The workflow decodes them at runtime to:
fastlane/play-store-account.jsonfastlane/AuthKey.p8Practical Validation / Testing
zipalign -P 16locally on a release Android build artifact using the guidance in the linked 16KB reference.workflow_dispatchwith selectedandroid_trackandios_release_target, orvX.Y.Z)Files
skills/deployment/**README.md,.claude-plugin/marketplace.json