Skip to content

Add CI job for buildind and testing on 32bit big endian#2941

Merged
Rot127 merged 1 commit into
capstone-engine:nextfrom
trufae:mipsbe
Jun 1, 2026
Merged

Add CI job for buildind and testing on 32bit big endian#2941
Rot127 merged 1 commit into
capstone-engine:nextfrom
trufae:mipsbe

Conversation

@trufae
Copy link
Copy Markdown
Contributor

@trufae trufae commented May 29, 2026

Your checklist for this pull request

  • I've documented or updated the documentation of every API function and struct this PR changes.
  • I've added tests that prove my fix is effective or that my feature works (if possible)

Detailed description

...

Test plan

...

Closing issues

...

@github-actions github-actions Bot added the Github-files Github related files label May 29, 2026
Copy link
Copy Markdown
Collaborator

@Rot127 Rot127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cross builds are already in CrossBuilds.yaml, please extend it with Mips 32bit BE

@trufae
Copy link
Copy Markdown
Contributor Author

trufae commented May 29, 2026

btw, would you like to use dependabot? there are several actions that are old (checkout is v4 and last one is v6 for example)

@trufae
Copy link
Copy Markdown
Contributor Author

trufae commented May 29, 2026

Also i think the big endian bug i found was only affecting v5. not sure if its' worth adding a regression test for next, looking forward for the v6

@trufae
Copy link
Copy Markdown
Contributor Author

trufae commented May 29, 2026

The tests just confirm those bugs are not affecting next (which is good) i have also updated the checkout to v6, not sure if you really want that but i think it will be better to have dependabot do all those actions updates automatically and also evaluate to switch to ubuntu 26.04 even if its not really providing any benefit either.

Do you want me to push the patches fixing the bugs in v5?

@Rot127
Copy link
Copy Markdown
Collaborator

Rot127 commented May 29, 2026

Do you want me to push the patches fixing the bugs in v5?

This would be nice. I fixed the 32bit build here: #2796

But any kind of fix is welcome.

btw, would you like to use dependabot?

I added it a few weeks ago. But something broke and I forgot all the time to fix it.
Give me a second.

@trufae trufae force-pushed the mipsbe branch 2 times, most recently from 3b65c84 to 77aaff6 Compare May 29, 2026 17:05
@Rot127
Copy link
Copy Markdown
Collaborator

Rot127 commented May 29, 2026

Dependabot fix is here: #2942

Copy link
Copy Markdown
Collaborator

@Rot127 Rot127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove all changes except the tests.
Then I can merge

@Rot127 Rot127 merged commit b855156 into capstone-engine:next Jun 1, 2026
43 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Github-files Github related files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants