V5 be#2943
Open
trufae wants to merge 8 commits into
Open
Conversation
github-actions
Bot
added
X86
Rot127
requested changes
May 29, 2026
Collaborator
Rot127
left a comment
Rot127
left a comment
There was a problem hiding this comment.
Would you mind also applying the other changes from https://github.com/capstone-engine/capstone/pull/2796/changes#diff-8ab50bbaa9a6956702fed253c6b8d13be8f3c4b062faf4398af2053c731e9e82
There are not that many. Mostly formatting changes for the three archs here. Simply copy and paste should do the job.
| - name: C tests | ||
| if: ${{ matrix.config.skip_tests != true }} | ||
| run: | | ||
| ctest --test-dir build --output-on-failure -R '^capstone_' |
Collaborator
There was a problem hiding this comment.
In v5 this won't run all the tests which matter (MC and issues.cs). You need to run cstest additionally (see CITest.yml)
| echo "set(CMAKE_SYSROOT ${sysroot}/usr)" | ||
| echo "set(CMAKE_CROSSCOMPILING_EMULATOR ${qemu};-L;${sysroot})" | ||
| fi | ||
| } > build/toolchain.cmake |
Collaborator
There was a problem hiding this comment.
Could you commit the toolchain files as well? Not generating them here I mean.
It is a nice feature for people to quickly build it or at least have a decent reference.
Co-authored-by: Rot127 <45763064+Rot127@users.noreply.github.com>
Co-authored-by: Rot127 <45763064+Rot127@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i backported the crossbuilds ci jobs from the next branch to the v5 one.
that confirmed the bugs i found that are already fixed in v6, so i just fixed them here and added more tests: