fix: preserve subclass identity when unpickling Box#312
Closed
highoncomputers wants to merge 1 commit into
Closed
Conversation
When a subclass of Box is pickled and unpickled, nested Box objects within it were being reconstructed as the base Box class instead of the subclass. Changed the __new__ method to use cls instead of the hardcoded Box reference. Fixes #308
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a subclass of Box is pickled and unpickled, nested Box objects within it were reconstructed as the base
Boxclass instead of the subclass. The__new__method hardcodedBoxas the defaultbox_classinstead of usingcls, which is the actual class being instantiated.Changes
box/box.py: ChangedBoxtoclsin__new__method'sbox_classdefault assignmentType of Change
Related Issue
Fixes #308