Skip to content

chore: fix typographical and capitalization errors in docs and codebase #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Dark-Brain07 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore: fix typographical and capitalization errors in docs and codebase #268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions apps/firebase/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,17 +5,17 @@ A firebase function that faucets addresses

## Funding the accounts

The accounts are normal EOAs. send CELO via transfer or simple transaction.
The accounts are normal EOAs. Send CELO via transfer or simple transaction.


## How to qa

push to the staging branch. this branch is the only non master branch that can be used with captcha and deployment
## How to QA
Push to the staging branch. This branch is the only non-master branch that can be used with captcha and deployment.


## How to deploy

Deployment is done thru a github action. see deploy-chain.yaml
Deployment is done through a GitHub Action. See deploy-chain.yaml

## ✍️ <a id="contributing"></a>Contributing

Expand Down
6 changes: 3 additions & 3 deletions apps/firebase/src/database-helper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ export async function processRequest(
}
} catch (err) {
logExecutionResult(snap.key, ExecutionResult.OtherErr)
console.error(`req(${snap.key}): ERROR proccessRequest`, err)
console.error(`req(${snap.key}): ERROR processRequest`, err)
await snap.ref.update({ status: RequestStatus.Failed })
throw err
}
Expand Down Expand Up @@ -122,7 +122,7 @@ async function dispatchCeloFunds(

const celoTxhash = await celo.transferCelo(address, amount)
console.info(
`req(${snap.key}): CELO Transaction Submited to mempool. txhash:${celoTxhash}`,
`req(${snap.key}): CELO Transaction Submitted to mempool. txhash:${celoTxhash}`,
)
await snap.ref.update({ celoTxhash })
return celoTxhash
Expand Down Expand Up @@ -289,7 +289,7 @@ export class AccountPool {
* Try to set `locked` field to true.
*
* @param lockRef Reference to lock field
* @returns Wether it sucessfully updated the field
* @returns Whether it successfully updated the field
*/
private async trySetLockField(lockRef: Reference) {
const txres = await lockRef.transaction((curr: boolean) => {
Expand Down
6 changes: 3 additions & 3 deletions readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,14 @@ This Repo contains the code for the celo testnets faucet. This is contained in 2

The web app deploys automatically to vercel.

The deploy-chains gh actions deploys functions to staging and production envronments from staging and master branches respectively
The deploy-chains gh actions deploys functions to staging and production environments from staging and master branches respectively

Note other branches are not deployed autamtically but can be by manually triggering the flow
Note other branches are not deployed automatically but can be by manually triggering the flow


## Setup

### Wep app
### Web app

To set up the web app to run locally:

Expand Down