Update to latest Spike version#87
Conversation
Disable DTB discovery, which was introduced in riscv-software-src/riscv-isa-sim@2c94ea4
BilalAli10x
left a comment
BilalAli10x
left a comment
There was a problem hiding this comment.
I verified this fix locally. Adding the false argument to the sim_t constructor is required for compatibility with the latest Spike. My riscv-vector-tests build is now passing Stage 1 and Stage 2 with this change.
|
Could you update the hash and pull the latest? Since then, two new vector extensions, Zvabd and Zvzip, have been added (not yet ratified) to Spike, along with a fix to the RVV Crypto group. |
|
Sure! I checked locally, and no other API changes seem to have occured. |
|
There are failures in the RV64_Zvl64 combo. |
|
There are, but I have no clue why this particular check would fail when the others all succeed. Maybe someone with more experience with the project may have some insights? |
|
@jmgorius Unfortunately, I don’t have a straightforward fix to propose. However, if you have the time, I would suggest gradually replacing the current spike hash with older ones and checking which version still passes. This should help narrow down where things start to break. In the Makefile, you can provide a PATTERN. For now, generating cases only for vmulh_vv should significantly speed up testing and make it easier to isolate the issue. |
|
After some bisecting, it turns out that this Spike commit is the culprit: riscv-software-src/riscv-isa-sim@d1e34d0 I am trying to figure out how to fix the issue. |
4 participants
Disable DTB discovery, which was introduced in riscv-software-src/riscv-isa-sim@2c94ea4