[BUG](fn-consumer): Use live backfill frontier#7423
Merged
Conversation
Contributor
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
This comment has been minimized.
This comment has been minimized.
tanujnay112
force-pushed
the
codex/fn-backfill-live-frontier
branch
from
July 10, 2026 22:24
74383c1 to
b90231a
Compare
rescrv
approved these changes
Jul 13, 2026
| .collection_info | ||
| .collection | ||
| .log_position, | ||
| ) as u64, |
Contributor
There was a problem hiding this comment.
I realize we should never hit this. It still feels wrong to just cast.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description of changes
During attached-function backfill, the executor processes the live record segment through the collection's current log position, but the batch was labeled with the earlier incremental fetch frontier. Idempotent functions therefore saved a frontier behind the records they had actually processed, allowing later executions to count overlapping records again.
is_for_backfillsignal.pulled_log_offset.completion_offsettopulled_log_offsetto reflect its actual meaning.Test plan
cargo test -p worker test_resolve_pulled_log_offsetcargo test -p worker count_to_file_async::testscargo clippy -p worker --all-targets --all-features -- -D warningscargo fmt --all -- --checkMigration plan
No migration required. This changes an internal Rust field name and attached-function backfill frontier selection.
Observability plan
Existing attached-function completion logs expose the resulting completion frontier.
Documentation Changes
None; no user-facing API changes.