Skip to content

fix(m365): update example directory to have all defined variables#29

Merged
jacdavi merged 1 commit intomainfrom
fix/example_main
Apr 14, 2026
Merged

fix(m365): update example directory to have all defined variables#29
jacdavi merged 1 commit intomainfrom
fix/example_main

Conversation

@jacdavi
Copy link
Copy Markdown
Collaborator

@jacdavi jacdavi commented Apr 14, 2026

🗣 Description

Updates m365 Terraform example environment files to include all defined variables.

Previously, variables.tf was missing output_storage_container_sas
main.tf was also missing firewall, output_storage_container_sas, create_app, container_memory_gb, and prefix_override

Additionally, main.tf was updated so variables appear in the same order as the variables files

💭 Motivation and context

Not all options were properly exposed prior to this change. Closes #28

🧪 Testing

Verified all variables now included. Also verified terraform apply still worked as expected.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • PR targets the correct parent branch (e.g., main or release-name) for merge.
  • Changes are limited to a single goal - eschew scope creep!
  • Changes are sized such that they do not touch excessive number of files.
  • All future TODOs are captured in issues, which are referenced in code comments.
  • Related issues these changes resolve are linked preferably via closing keywords.
  • All relevant repo and/or project documentation updated to reflect these changes.
  • All automated checks (e.g., linting, static analysis, unit/smoke tests) passed.

✅ Post-merge checklist

  • Feature branch deleted after merge to clean up repository.
  • Verified that all checks pass on parent branch (e.g., main or release-name) after merge.

update order in main.tf to match variables.tf file
@jacdavi jacdavi merged commit 7c3034e into main Apr 14, 2026
7 checks passed
@jacdavi jacdavi deleted the fix/example_main branch April 20, 2026 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[m365] create_app variable ignored

1 participant