fix: honour -o json/custom across missing and broken commands#586
Merged
giornetta merged 10 commits intoMay 27, 2026
Merged
Conversation
…fig and network show
giornetta
reviewed
May 12, 2026
network show: guard VLAN-specific fields (vlan_id, physical_interface, allocation_pool_v4_start, allocation_pool_v4_end) behind VlanID \!= 0 so they are omitted from JSON/custom output on non-VLAN networks. Use strconv.Itoa for VlanID, consistent with network list. Move gateway_ipv4 outside the VLAN guard -- it is relevant to all networks. instance recovery: restore instance UUID in human output, shown in parentheses after the hostname.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several commands ignored the
-o jsonand-o customflags, alwaysprinting plain text regardless. One command (
kubernetes cluster remove)had a latent bug where
-o jsonalso triggered the custom formatter.Missing output format handling (always printed plain text):
kubernetes node-pool instance-deletekubernetes cluster remove(also hadWriteCustomOutputinside the"json"case, so-o jsonproduced both outputs)apikey remove/apikey setinstance public-ip/instance recoverykubernetes update-kubeconfignetwork showAlso fixed in
instance recovery: afmt.Println("Instance ID is: …")that fired before the API call, unconditionally, on everyinvocation.