Skip to content

Fixed: Cannot set property 'isReadOnly' of null#138

Open
Muukuro wants to merge 1 commit into
ckeditor:masterfrom
Muukuro:patch-1
Open

Fixed: Cannot set property 'isReadOnly' of null#138
Muukuro wants to merge 1 commit into
ckeditor:masterfrom
Muukuro:patch-1

Conversation

@Muukuro
Copy link
Copy Markdown

@Muukuro Muukuro commented Jul 3, 2020

When the prop disabled is mutated AFTER the component has mounted, but BEFORE this.editor.create is resolved, this results in an error "TypeError: Cannot set property 'isReadOnly' of null". Checking if the instance is successfully initialized prevents this error.

Suggested merge commit message (convention)

Type: Message. Closes #000.


Additional information

For example – encountered issues, assumptions you had to make, other affected tickets, etc.

When the prop `disabled` is mutated AFTER the component has mounted, but BEFORE `this.editor.create` is resolved, this results in an error "TypeError: Cannot set property 'isReadOnly' of null". Checking if the instance is successfully initialized prevents this error.
@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 118

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-2.4%) to 97.619%

Totals Coverage Status
Change from base Build 117: -2.4%
Covered Lines: 32
Relevant Lines: 32

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants