Skip to content

ci: pin @stoplight/spectral-rulesets to 1.22.2 #1966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carlhoerberg merged 3 commits into from
May 25, 2026
Merged

ci: pin @stoplight/spectral-rulesets to 1.22.2 #1966

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7767ac3
ci: pin @stoplight/spectral-rulesets to 1.22.2
viktorerlingsson May 25, 2026
76fa549
use long flags
viktorerlingsson May 25, 2026
85fbb33
use long form for both packages
viktorerlingsson May 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ lint-js:

.PHONY: lint-openapi
lint-openapi:
npx --package=@stoplight/spectral-cli spectral --ruleset openapi/.spectral.json lint static/docs/openapi.yaml
npx --yes --package=@stoplight/spectral-cli -p @stoplight/spectral-rulesets@1.22.2 spectral --ruleset openapi/.spectral.json lint static/docs/openapi.yaml
Comment thread
viktorerlingsson marked this conversation as resolved.
Outdated
Comment thread
viktorerlingsson marked this conversation as resolved.
Outdated
Copy link
Copy Markdown
Member

@dentarg dentarg May 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This must be what we want?

Suggested change
npx --yes --package=@stoplight/spectral-cli -p @stoplight/spectral-rulesets@1.22.2 spectral --ruleset openapi/.spectral.json lint static/docs/openapi.yaml
npx --yes --package=@stoplight/spectral-rulesets@1.22.2 spectral --ruleset openapi/.spectral.json lint static/docs/openapi.yaml

Copy link
Copy Markdown
Member Author

@viktorerlingsson viktorerlingsson May 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be

npx --yes --package=@stoplight/spectral-cli --package=@stoplight/spectral-rulesets@1.22.2 spectral --ruleset openapi/.spectral.json lint static/docs/openapi.yaml

Copy link
Copy Markdown
Member

@dentarg dentarg May 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah right, it is the @stoplight/spectral-cli dependency @stoplight/spectral-rulesets we need to pin. That makes me wonder how many other dependencies @stoplight/spectral-cli have? That we aren't pinning?

...19 in total it seems: https://www.npmjs.com/package/@stoplight/spectral-cli?activeTab=dependencies 😐


.PHONY: test
test: lib views
Expand Down
Loading