refactor(navigation): drop V0 suffix from planner types#2008
Open
NathanDrake2406 wants to merge 1 commit into
Open
refactor(navigation): drop V0 suffix from planner types#2008NathanDrake2406 wants to merge 1 commit into
NathanDrake2406 wants to merge 1 commit into
Conversation
The navigation planner's public and internal types were suffixed `V0` (RouteSnapshotV0, NavigationDecisionV0, FlightResultV0, and 19 others). The suffix implied a versioning scheme that never materialized — there is no V1, and the schema-version concerns it hinted at are carried explicitly elsewhere (NAVIGATION_TRACE_SCHEMA_VERSION, CACHE_PROOF_MODEL_SCHEMA_VERSION). The bare suffix was pure noise at every call site. Rename all 22 `…V0` planner types to their unsuffixed names across the planner, the browser state/entry/action modules, and the planner test suite. Pure mechanical rename: no behavior change, all 295 planner and browser-entry tests pass unchanged.
commit: |
NathanDrake2406
force-pushed
the
worktree-promote-operation-token
branch
from
29af69f to
42cfc71
Compare
NathanDrake2406
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Renames all 22
…V0-suffixed navigation planner types to their unsuffixed names —RouteSnapshotV0→RouteSnapshot,NavigationDecisionV0→NavigationDecision,FlightResultV0→FlightResult, and 19 others — across the planner, the browser state/entry/action modules, and the planner test suite (205 occurrences, 10 files).Why
The
V0suffix implied a versioning scheme that never materialized — there is no V1, and the schema-version concerns it hinted at are carried explicitly elsewhere (NAVIGATION_TRACE_SCHEMA_VERSION,CACHE_PROOF_MODEL_SCHEMA_VERSION). The bare suffix was pure noise at every call site.Approach
Pure mechanical rename. Two comment references to the old naming were reworded; no identifier collisions (every de-suffixed name was free). No behavior change.
Validation
All 295 planner + browser-entry tests pass unchanged.
vp check(format, type-aware lint) and knip green.Stacked PR
This is the base of a two-PR stack for #1790 PR 5. The logic change — promoting
OperationTokento the navigation eligibility authority — sits on top in a separate (draft) PR so this rename reviews as a clean, behavior-free diff. The follow-up will rebase to logic-only once this merges.Refs #1790.