fix: misc code quality improvements#1032
Open
123456wda wants to merge 1 commit into
Open
Conversation
- compose/graph.go: use fmt.Errorf instead of errors.New(fmt.Sprintf(...)) - adk/utils.go: guard concatInstructions against empty input panic - adk/flow.go: rename ok_/ok__ to descriptive variable names - adk/react.go: extract hardcoded maxIter magic number to named constant Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
errors.New(fmt.Sprintf(...))with idiomaticfmt.ErrorfconcatInstructionsto prevent potential index-out-of-bounds panicok_/ok__variables to descriptive names (isSubAgent,hasNext) for better readabilitymaxItervalue20to a named constantdefaultMaxIterationsTest plan
go build ./compose/... ./adk/...passesgo test ./compose/...passesgo test ./adk/passes