test(rpcinfo): cover frozen RPCInfo after recycle#1969
Open
Haihan-Jiang wants to merge 1 commit into
Open
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds regression coverage for the documented async-safe
FreezeRPCInfopath related to #1958. The test freezes anRPCInfo, returns the original pooled value withPutRPCInfo, and verifies that the frozen copy still retains endpoint, invocation, and timeout configuration values while omitting stats.Why
Issue #1958 discusses the risk of keeping
GetRPCInfo(ctx)references past the request lifecycle when rpcinfo pooling is enabled. This test locks down the expected behavior for the safer frozen snapshot path.Tests
go test ./pkg/rpcinfogo test -race ./pkg/rpcinfo